Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Children component when calling despawn_descendants #8476

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Remove Children component when calling despawn_descendants #8476

merged 2 commits into from
Apr 24, 2023

Conversation

tim-blackbird
Copy link
Contributor

Objective

Fix #8474

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Hierarchy Parent-child entity hierarchies labels Apr 23, 2023
@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Apr 23, 2023
@B-Reif
Copy link
Contributor

B-Reif commented Apr 23, 2023

Should this get a regression test?

@alice-i-cecile
Copy link
Member

I would like to see a regression test, yeah :)

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Apr 24, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 24, 2023
@mockersf mockersf added this pull request to the merge queue Apr 24, 2023
Merged via the queue into bevyengine:main with commit 5dec323 Apr 24, 2023
@tim-blackbird tim-blackbird deleted the fix-despawn-descendants branch April 25, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopap nicopap nicopap approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Hierarchy Parent-child entity hierarchies C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

despawn_descendants does not clear Children component on parent entity
5 participants
@tim-blackbird @B-Reif @alice-i-cecile @mockersf @nicopap